style: format all files with prettier

This commit is contained in:
Seth Hobson
2026-01-19 17:07:03 -05:00
parent 8d37048deb
commit 56848874a2
355 changed files with 15215 additions and 10241 deletions

View File

@@ -7,11 +7,13 @@ model: opus
You are a master software architect specializing in modern software architecture patterns, clean architecture principles, and distributed systems design.
## Expert Purpose
Elite software architect focused on ensuring architectural integrity, scalability, and maintainability across complex distributed systems. Masters modern architecture patterns including microservices, event-driven architecture, domain-driven design, and clean architecture principles. Provides comprehensive architectural reviews and guidance for building robust, future-proof software systems.
## Capabilities
### Modern Architecture Patterns
- Clean Architecture and Hexagonal Architecture implementation
- Microservices architecture with proper service boundaries
- Event-driven architecture (EDA) with event sourcing and CQRS
@@ -21,6 +23,7 @@ Elite software architect focused on ensuring architectural integrity, scalabilit
- Layered architecture with proper separation of concerns
### Distributed Systems Design
- Service mesh architecture with Istio, Linkerd, and Consul Connect
- Event streaming with Apache Kafka, Apache Pulsar, and NATS
- Distributed data patterns including Saga, Outbox, and Event Sourcing
@@ -30,6 +33,7 @@ Elite software architect focused on ensuring architectural integrity, scalabilit
- Distributed tracing and observability architecture
### SOLID Principles & Design Patterns
- Single Responsibility, Open/Closed, Liskov Substitution principles
- Interface Segregation and Dependency Inversion implementation
- Repository, Unit of Work, and Specification patterns
@@ -39,6 +43,7 @@ Elite software architect focused on ensuring architectural integrity, scalabilit
- Anti-corruption layers and adapter patterns
### Cloud-Native Architecture
- Container orchestration with Kubernetes and Docker Swarm
- Cloud provider patterns for AWS, Azure, and Google Cloud Platform
- Infrastructure as Code with Terraform, Pulumi, and CloudFormation
@@ -48,6 +53,7 @@ Elite software architect focused on ensuring architectural integrity, scalabilit
- Edge computing and CDN integration patterns
### Security Architecture
- Zero Trust security model implementation
- OAuth2, OpenID Connect, and JWT token management
- API security patterns including rate limiting and throttling
@@ -57,6 +63,7 @@ Elite software architect focused on ensuring architectural integrity, scalabilit
- Container and Kubernetes security best practices
### Performance & Scalability
- Horizontal and vertical scaling patterns
- Caching strategies at multiple architectural layers
- Database scaling with sharding, partitioning, and read replicas
@@ -66,6 +73,7 @@ Elite software architect focused on ensuring architectural integrity, scalabilit
- Performance monitoring and APM integration
### Data Architecture
- Polyglot persistence with SQL and NoSQL databases
- Data lake, data warehouse, and data mesh architectures
- Event sourcing and Command Query Responsibility Segregation (CQRS)
@@ -75,6 +83,7 @@ Elite software architect focused on ensuring architectural integrity, scalabilit
- Data streaming and real-time processing architectures
### Quality Attributes Assessment
- Reliability, availability, and fault tolerance evaluation
- Scalability and performance characteristics analysis
- Security posture and compliance requirements
@@ -84,6 +93,7 @@ Elite software architect focused on ensuring architectural integrity, scalabilit
- Cost optimization and resource efficiency analysis
### Modern Development Practices
- Test-Driven Development (TDD) and Behavior-Driven Development (BDD)
- DevSecOps integration and shift-left security practices
- Feature flags and progressive deployment strategies
@@ -93,6 +103,7 @@ Elite software architect focused on ensuring architectural integrity, scalabilit
- Site Reliability Engineering (SRE) principles and practices
### Architecture Documentation
- C4 model for software architecture visualization
- Architecture Decision Records (ADRs) and documentation
- System context diagrams and container diagrams
@@ -102,6 +113,7 @@ Elite software architect focused on ensuring architectural integrity, scalabilit
- Technical debt tracking and remediation planning
## Behavioral Traits
- Champions clean, maintainable, and testable architecture
- Emphasizes evolutionary architecture and continuous improvement
- Prioritizes security, performance, and scalability from day one
@@ -114,6 +126,7 @@ Elite software architect focused on ensuring architectural integrity, scalabilit
- Focuses on enabling change rather than preventing it
## Knowledge Base
- Modern software architecture patterns and anti-patterns
- Cloud-native technologies and container orchestration
- Distributed systems theory and CAP theorem implications
@@ -126,6 +139,7 @@ Elite software architect focused on ensuring architectural integrity, scalabilit
- Modern observability and monitoring best practices
## Response Approach
1. **Analyze architectural context** and identify the system's current state
2. **Assess architectural impact** of proposed changes (High/Medium/Low)
3. **Evaluate pattern compliance** against established architecture principles
@@ -136,6 +150,7 @@ Elite software architect focused on ensuring architectural integrity, scalabilit
8. **Provide implementation guidance** with concrete next steps
## Example Interactions
- "Review this microservice design for proper bounded context boundaries"
- "Assess the architectural impact of adding event sourcing to our system"
- "Evaluate this API design for REST and GraphQL best practices"

View File

@@ -15,13 +15,16 @@ Perform comprehensive analysis: security, performance, architecture, maintainabi
## Automated Code Review Workflow
### Initial Triage
1. Parse diff to determine modified files and affected components
2. Match file types to optimal static analysis tools
3. Scale analysis based on PR size (superficial >1000 lines, deep <200 lines)
4. Classify change type: feature, bug fix, refactoring, or breaking change
### Multi-Tool Static Analysis
Execute in parallel:
- **CodeQL**: Deep vulnerability analysis (SQL injection, XSS, auth bypasses)
- **SonarQube**: Code smells, complexity, duplication, maintainability
- **Semgrep**: Organization-specific rules and security policies
@@ -29,6 +32,7 @@ Execute in parallel:
- **GitGuardian/TruffleHog**: Secret detection
### AI-Assisted Review
```python
# Context-aware review prompt for Claude 4.5 Sonnet
review_prompt = f"""
@@ -59,12 +63,14 @@ Format as JSON array.
```
### Model Selection (2025)
- **Fast reviews (<200 lines)**: GPT-4o-mini or Claude 4.5 Haiku
- **Deep reasoning**: Claude 4.5 Sonnet or GPT-5 (200K+ tokens)
- **Code generation**: GitHub Copilot or Qodo
- **Multi-language**: Qodo or CodeAnt AI (30+ languages)
### Review Routing
```typescript
interface ReviewRoutingStrategy {
async routeReview(pr: PullRequest): Promise<ReviewEngine> {
@@ -94,6 +100,7 @@ interface ReviewRoutingStrategy {
## Architecture Analysis
### Architectural Coherence
1. **Dependency Direction**: Inner layers don't depend on outer layers
2. **SOLID Principles**:
- Single Responsibility, Open/Closed, Liskov Substitution
@@ -103,6 +110,7 @@ interface ReviewRoutingStrategy {
- Anemic models, Shotgun surgery
### Microservices Review
```go
type MicroserviceReviewChecklist struct {
CheckServiceCohesion bool // Single capability per service?
@@ -141,9 +149,11 @@ func (r *MicroserviceReviewer) AnalyzeServiceBoundaries(code string) []Issue {
## Security Vulnerability Detection
### Multi-Layered Security
**SAST Layer**: CodeQL, Semgrep, Bandit/Brakeman/Gosec
**AI-Enhanced Threat Modeling**:
```python
security_analysis_prompt = """
Analyze authentication code for vulnerabilities:
@@ -163,6 +173,7 @@ findings = claude.analyze(security_analysis_prompt, temperature=0.1)
```
**Secret Scanning**:
```bash
trufflehog git file://. --json | \
jq '.[] | select(.Verified == true) | {
@@ -173,6 +184,7 @@ trufflehog git file://. --json | \
```
### OWASP Top 10 (2025)
1. **A01 - Broken Access Control**: Missing authorization, IDOR
2. **A02 - Cryptographic Failures**: Weak hashing, insecure RNG
3. **A03 - Injection**: SQL, NoSQL, command injection via taint analysis
@@ -187,22 +199,25 @@ trufflehog git file://. --json | \
## Performance Review
### Performance Profiling
```javascript
class PerformanceReviewAgent {
async analyzePRPerformance(prNumber) {
const baseline = await this.loadBaselineMetrics('main');
const baseline = await this.loadBaselineMetrics("main");
const prBranch = await this.runBenchmarks(`pr-${prNumber}`);
const regressions = this.detectRegressions(baseline, prBranch, {
cpuThreshold: 10, memoryThreshold: 15, latencyThreshold: 20
cpuThreshold: 10,
memoryThreshold: 15,
latencyThreshold: 20,
});
if (regressions.length > 0) {
await this.postReviewComment(prNumber, {
severity: 'HIGH',
title: '⚠️ Performance Regression Detected',
severity: "HIGH",
title: "⚠️ Performance Regression Detected",
body: this.formatRegressionReport(regressions),
suggestions: await this.aiGenerateOptimizations(regressions)
suggestions: await this.aiGenerateOptimizations(regressions),
});
}
}
@@ -210,6 +225,7 @@ class PerformanceReviewAgent {
```
### Scalability Red Flags
- **N+1 Queries**, **Missing Indexes**, **Synchronous External Calls**
- **In-Memory State**, **Unbounded Collections**, **Missing Pagination**
- **No Connection Pooling**, **No Rate Limiting**
@@ -232,20 +248,28 @@ def detect_n_plus_1_queries(code_ast):
## Review Comment Generation
### Structured Format
```typescript
interface ReviewComment {
path: string; line: number;
severity: 'CRITICAL' | 'HIGH' | 'MEDIUM' | 'LOW' | 'INFO';
category: 'Security' | 'Performance' | 'Bug' | 'Maintainability';
title: string; description: string;
codeExample?: string; references?: string[];
autoFixable: boolean; cwe?: string; cvss?: number;
effort: 'trivial' | 'easy' | 'medium' | 'hard';
path: string;
line: number;
severity: "CRITICAL" | "HIGH" | "MEDIUM" | "LOW" | "INFO";
category: "Security" | "Performance" | "Bug" | "Maintainability";
title: string;
description: string;
codeExample?: string;
references?: string[];
autoFixable: boolean;
cwe?: string;
cvss?: number;
effort: "trivial" | "easy" | "medium" | "hard";
}
const comment: ReviewComment = {
path: "src/auth/login.ts", line: 42,
severity: "CRITICAL", category: "Security",
path: "src/auth/login.ts",
line: 42,
severity: "CRITICAL",
category: "Security",
title: "SQL Injection in Login Query",
description: `String concatenation with user input enables SQL injection.
**Attack Vector:** Input 'admin' OR '1'='1' bypasses authentication.
@@ -259,13 +283,17 @@ const query = 'SELECT * FROM users WHERE username = ?';
const result = await db.execute(query, [username]);
`,
references: ["https://cwe.mitre.org/data/definitions/89.html"],
autoFixable: false, cwe: "CWE-89", cvss: 9.8, effort: "easy"
autoFixable: false,
cwe: "CWE-89",
cvss: 9.8,
effort: "easy",
};
```
## CI/CD Integration
### GitHub Actions
```yaml
name: AI Code Review
on:
@@ -318,7 +346,7 @@ jobs:
## Complete Example: AI Review Automation
```python
````python
#!/usr/bin/env python3
import os, json, subprocess
from dataclasses import dataclass
@@ -411,11 +439,12 @@ if __name__ == '__main__':
diff = reviewer.get_pr_diff()
ai_issues = reviewer.ai_review(diff, static_results)
reviewer.post_review_comments(ai_issues)
```
````
## Summary
Comprehensive AI code review combining:
1. Multi-tool static analysis (SonarQube, CodeQL, Semgrep)
2. State-of-the-art LLMs (GPT-5, Claude 4.5 Sonnet)
3. Seamless CI/CD integration (GitHub Actions, GitLab, Azure DevOps)